Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use file(GLOB ...) to collect source files #444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhmu
Copy link

@zhmu zhmu commented Oct 13, 2021

This is specifically recommended against in the CMake documentation [1]:

"We do not recommend using GLOB to collect a list of source files from your
source tree. [...]"

[1] https://cmake.org/cmake/help/v3.15/command/file.html#filesystem

This is specifically recommended against in the CMake documentation [1]:

"We do not recommend using GLOB to collect a list of source files from your
source tree. [...]"

[1] https://cmake.org/cmake/help/v3.15/command/file.html#filesystem
@james-moran-ea
Copy link
Contributor

Hi there,
We just pushed a new CI workflow that uses github actions since our existing travis CI hasn't been running on new PRs. Could you sync down the latest changes and update this PR? Once those checks succeed, we can move forward with this :)
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants