Add react-native dependency to resolve it correctly. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add react-native package to dependencies to get the metro bundler to resolve the react-native CLI tool correctly: https://github.com/facebook/metro/blob/main/packages/metro-resolver/src/resolve.js#L137
This is also already included in the default non-base composites automatically:
https://github.com/electrode-io/electrode-native/blob/master/ern-composite-gen/src/GeneratedComposite.ts#L77
Failure to include the dependency will result in ambiguity in finding the right react-native CLI tool to run.