Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/openai-reasoning-store-true.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@electric-ax/agents': patch
---

Force `store: true` for built-in OpenAI reasoning model payloads so reasoning/tool-call continuations can replay `rs_*` reasoning items without follow-up requests failing due to missing persisted items.
5 changes: 5 additions & 0 deletions packages/agents/src/model-catalog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,11 @@ function withProviderPayloadDefaults(

return {
...body,
// OpenAI Responses reasoning/tool-call continuations replay rs_*
// reasoning items. With store:false, OpenAI does not persist those
// items server-side, which can make follow-up requests fail with
// "Item with id ... not found". Keep Responses stateful for built-ins.
store: true,
reasoning: {
...existingReasoning,
effort,
Expand Down
42 changes: 42 additions & 0 deletions packages/agents/test/model-catalog.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ describe(`model catalog`, () => {
)

expect(payload).toEqual({
store: true,
reasoning: { effort: `minimal` },
})
})
Expand All @@ -145,10 +146,51 @@ describe(`model catalog`, () => {
)

expect(payload).toEqual({
store: true,
reasoning: { effort: `high` },
})
})

it(`forces store true only for OpenAI reasoning model payloads`, async () => {
const openAiCatalog = await createBuiltinModelCatalog()
const openAiConfig = resolveBuiltinModelConfig(openAiCatalog!, {
model: `openai:gpt-5`,
})

expect(
openAiConfig.onPayload!(
{ store: false, reasoning: { effort: `none` } },
{} as any
)
).toEqual({
store: true,
reasoning: { effort: `minimal` },
})

delete process.env.OPENAI_API_KEY
process.env.DEEPSEEK_API_KEY = `test-deepseek-key`
vi.stubGlobal(
`fetch`,
vi.fn(async (url: string) => {
if (String(url).includes(`deepseek.com`)) {
return {
ok: true,
status: 200,
json: async () => ({ data: [{ id: `deepseek-v4-flash` }] }),
}
}
return { ok: false, status: 401, json: async () => ({}) }
})
)

const deepseekCatalog = await createBuiltinModelCatalog()
const deepseekConfig = resolveBuiltinModelConfig(deepseekCatalog!, {
model: `deepseek:deepseek-v4-flash`,
})

expect(deepseekConfig.onPayload).toBeUndefined()
})

it(`does not expose providers whose keys are rejected`, async () => {
vi.stubGlobal(
`fetch`,
Expand Down
Loading