Conversation
…to periodically report on build progress
…leanup the smc-upgrader-plan.md
- Only commit source changes when commitAllChangesOnCompletion flag is true - Don't commit plan file when marking step as "in progress" (repo may be in MERGING state) - Add shouldCommit parameter to savePlan method for explicit control - Add test for smc-upgrader steps with commitAllChangesOnCompletion=false Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add versionFilter field to AiPlanStep for filtering steps by target version - Update AiPlanGenerator to skip steps where versionFilter doesn't match target version - Add test for versionFilter functionality This allows steps like "Run Automated Jakarta Source Migration" to only appear in upgrade plans when targeting a specific version (e.g., 8.7.x). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…aude - Add isValidationOnlyStep() method to AiPlanStep - Add executeValidationOnlyStep() method to AiPlanExecutor - Update config to use validation-only for Jakarta Source Migration step - Add tests for validation-only step success and failure scenarios The validation-only tool type runs the validation command without invoking Claude, useful for automated migration steps. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ermissions Added --ai:skip-permissions CLI parameter that makes the dangerous permissions flag opt-in rather than always passed to Claude. When specified with --ai:start, stores the setting in the plan file. When --ai:continue runs, checks both CLI flag and plan indicator to determine whether to pass --dangerously-skip-permissions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…failures and resolving compilation failures
When a step is in progress and the user chooses [V] to validate, if validation fails the tool now exits immediately instead of showing another prompt asking "Was this step successfully completed?". This avoids redundant prompts since the validation failure message already instructs the user to review and retry. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Added missing isValidationOnlyStep() check in the menu's [E] execute option so validation-only steps can be executed when resumed from an in-progress state. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Created ToolTypeEnum with SMC_UPGRADER, CLAUDE, and VALIDATION_ONLY values - Changed AiPlanStep.tool from String to ToolTypeEnum - Removed isClaudeStep(), isSmcUpgraderStep(), isValidationOnlyStep() methods - Added executeStepByToolType() method in AiPlanExecutor using switch statement - Added GSON @SerializedName annotations for JSON deserialization - Updated MarkdownParser to convert string to enum using ToolTypeEnum.fromString() - Updated MarkdownWriter to output enum's string value - Updated all tests to use enum constants Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
gdenning
commented
Jan 30, 2026
src/main/java/com/elasticpath/tools/smcupgrader/ai/AiPlanExecutor.java
Outdated
Show resolved
Hide resolved
gdenning
commented
Jan 30, 2026
| ) | ||
| private File workingDir; | ||
|
|
||
| @CommandLine.Option(names = { "-u", "--upstream-repository-url" }, |
Collaborator
Author
There was a problem hiding this comment.
There's no need for this to be overridable. Maybe open a new ticket to remove this option.
Move DEFAULT_UPSTREAM_REPO_URL and PLAN_FILE_NAME constants from SMCUpgraderCLI, AiPlanExecutor, and AiPlanGenerator into a new centralized Constants class to eliminate duplication. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.