[Backport 8.x] benchmark script #17283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsions (elastic#16421) - add becnhmark dashboard and related save objects - add one buildkite pipeline to test against multiple versions - remove null field in json - add `FLOG_FILE_CNT`, `VAULT_PATH`, `TAGS`
- split main.sh to core.sh and main.sh - rename all.sh to marathon.sh - fix vault expiry issue for long running task - fix unable to call main function - update save object runtime field `release` to return true when `version` contains "SNAPSHOT"
- add instruction to run benchmark in v8 with `xpack.monitoring.allow_legacy_collection` - remove scripted field 5m_num from dashboards
migrate benchmark to the new artifacts-api
Introduce a new flag to explicitly permit legacy monitoring (elastic#16586)
kaisecheng
commented
Mar 6, 2025
| @@ -3,6 +3,7 @@ pipeline.workers: ${WORKER} | |||
| pipeline.batch.size: ${BATCH_SIZE} | |||
| queue.type: ${QTYPE} | |||
|
|
|||
| xpack.monitoring.allow_legacy_collection: true | |||
There was a problem hiding this comment.
this is the unclean backport of #16586
mashhurs
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
LGTM!
Note that this PR doesn't have any functionality effect.
I understand that in 8.x (or other branches) may contain unnecessary/confusing codes/endpoints (for example artifact API), so this backport doesn't hurt. The only thing I would ask is not to change catalog-info.yaml to keep CIs safe with CI build systems.
|
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of benchmark script PRs didn't backport to 8.x
This commit cherry-pick the missing PRs to one
[CI] benchmark uses the new artifacts-api (#17224)
[CI] benchmark readme (#16783)
Introduce a new flag to explicitly permit legacy monitoring (#16586) (Only take the benchmark script)
[ci] fix wrong queue type in benchmark marathon (#16465)
[CI] fix benchmark marathon (#16447)
[CI] benchmark dashboard and pipeline for testing against multiple versions (#16421)