Ensure plugin config marked :deprecated logs to deprecation logger #16863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lastic#16833) Previously when the `:deprecated` modifier was used in the plugin config DSL a log message was sent at `:warn` level to the main logger. This commit updates that message to be routed *only* to the deprecation logger.
Previously when the `:deprecated` modifier was used in the plugin config DSL a log message was sent at `:warn` level ONLY to the main logger. This commit updates that message to be routed *both* to the deprecation logger as well as the main logger. In 9.x this will *only* go to the deprecation logger.
This was referenced Jan 6, 2025
|
💚 Build Succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Log messages for configuration options marked as
:deprecatedin plugin config are now routed to the deprecation logger in addition to the main logger. In the next major version (9.0.0) these messages will only go to the deprecation logger.What does this PR do?
Ensure plugin config marked :deprecated logs to deprecation logger
Previously when the
:deprecatedmodifier was used in the plugin config DSL alog message was sent at
:warnlevel ONLY to the main logger. This commit updatesthat message to be routed both to the deprecation logger as well as the main
logger. In 9.x this will only go to the deprecation logger.
Why is it important/What is the impact to the user?
Instead of needing to check the main logger for deprecation messages logged at
WARNlevel, users can now expect to find the messages at the expected deprecation logger location. This allows them to find the complete set in the designated/expected destination. Note that the WARN message destined for the main logger is preserved in 8.x but in 9.x the message will only go to the deprecation logger.Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Author's Checklist
How to test this PR locally
Related issues
Closes #14988