[Reporting] Adds the enabled key to schema #68288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
tsullivan
added
release_note:skip
rudolf
approved these changes
Jun 4, 2020
💚 Build SucceededTo update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jun 4, 2020
tsullivan
added a commit
that referenced
this pull request
Jun 4, 2020
This was referenced Jun 22, 2020
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jun 22, 2020
tsullivan
added a commit
that referenced
this pull request
Jun 23, 2020
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Going along with #60998, Reporting plugin needs the schema to have the
enabledconfig option defined.Before, having xpack.reporting.enabled: false would cause Kibana startup to fail with an unrecognized config error.
For maintainers