Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search][Onboarding] Use new index details page #193058

Merged
merged 3 commits into from
Sep 16, 2024
Merged

[Search][Onboarding] Use new index details page #193058

merged 3 commits into from
Sep 16, 2024

Conversation

TattdCodeMonkey
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey commented Sep 16, 2024 •
edited by kibanamachine
Loading

Summary

  • Updated the empty state redirect to use the new index details page
  • Updated the empty state to only show "Run in Console" when cURL is the selected coding language.

@TattdCodeMonkey TattdCodeMonkey added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Search v8.16.0 labels Sep 16, 2024
@TattdCodeMonkey TattdCodeMonkey requested a review from a team as a code owner September 16, 2024 16:51
@TattdCodeMonkey TattdCodeMonkey force-pushed the search-indices/start-page-index-details-update branch from d617470 to 2d43664 Compare September 16, 2024 20:22
@TattdCodeMonkey TattdCodeMonkey added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed v8.16.0 labels Sep 16, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #21 / serverless observability UI Observability Logs Explorer DataSourceSelector with installed integrations and uncategorized data streams when open on the integrations tab should sort the integrations list by the clicked sorting option

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchIndices 69.3KB 69.3KB +62.0B

History

  • 💔 Build #234532 failed d6174706965320a06394637ec4f4020ada43599c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TattdCodeMonkey TattdCodeMonkey merged commit d6fdc82 into elastic:main Sep 16, 2024
21 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 16, 2024
@TattdCodeMonkey
[Search][Onboarding] Use new index details page (elastic#193058)
bd33eb9 
## Summary

- Updated the empty state redirect to use the new index details page
- Updated the empty state to only show "Run in Console" when cURL is the
selected coding language.

(cherry picked from commit d6fdc82)
@kibanamachine kibanamachine mentioned this pull request Sep 16, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 16, 2024
@kibanamachine @TattdCodeMonkey
[8.x] [Search][Onboarding] Use new index details page (#193058) (#193100
4d25d0f 
)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Search][Onboarding] Use new index details page
(#193058)](#193058)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Rodney
Norris","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-16T22:02:49Z","message":"[Search][Onboarding]
Use new index details page (#193058)\n\n## Summary\r\n\r\n- Updated the
empty state redirect to use the new index details page\r\n- Updated the
empty state to only show \"Run in Console\" when cURL is the\r\nselected
coding
language.","sha":"d6fdc825b4dd7c5878d32a01c4bd8ff9d5eec91e","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"[Search][Onboarding]
Use new index details
page","number":193058,"url":"https://github.com/elastic/kibana/pull/193058","mergeCommit":{"message":"[Search][Onboarding]
Use new index details page (#193058)\n\n## Summary\r\n\r\n- Updated the
empty state redirect to use the new index details page\r\n- Updated the
empty state to only show \"Run in Console\" when cURL is the\r\nselected
coding
language.","sha":"d6fdc825b4dd7c5878d32a01c4bd8ff9d5eec91e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193058","number":193058,"mergeCommit":{"message":"[Search][Onboarding]
Use new index details page (#193058)\n\n## Summary\r\n\r\n- Updated the
empty state redirect to use the new index details page\r\n- Updated the
empty state to only show \"Run in Console\" when cURL is the\r\nselected
coding language.","sha":"d6fdc825b4dd7c5878d32a01c4bd8ff9d5eec91e"}}]}]
BACKPORT-->

Co-authored-by: Rodney Norris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joemcelroy joemcelroy joemcelroy approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TattdCodeMonkey @kibana-ci @kibanamachine @joemcelroy