Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Endpoint] Re-enable skipped tests #179743

Conversation

paul-tavares
Copy link
Contributor

@paul-tavares paul-tavares commented Apr 1, 2024

Summary

Re-enables test skipped between March 29 and April 1 due to a problem (not fixed) with the Fleet Server docker image, which caused tests to fail with:

 info [cy.dfw] 0 attempts of creating endpoint host failed, reason for the last failure was Error: Command failed with exit code 1: multipass exec test-host-3626 -- sudo ./elastic-agent-8.14.0-SNAPSHOT-linux-arm64/elastic-agent install --insecure --force --url https://192.168.64.1:8220 --enrollment-token 
....
      {"log.level":"error","@timestamp":"2024-04-01T08:46:59.930-0400","log.origin":{"file.name":"remote/client.go","file.line":243},"message":"fleet requested a different api version \"2023-06-01\" but this is currently not implemented","http.request.id":"01HTCV5Q86GKT1KW682V7FH3MQ","ecs.version":"1.6.0"}

Issues (skipped tests) fixed with this PR:

fixes #168340
fixes #168284
fixes #169958
fixes #170373
fixes #170424
fixes #170563
fixes #172326
fixes #179744

@paul-tavares paul-tavares added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.14.0 labels Apr 1, 2024
@paul-tavares paul-tavares self-assigned this Apr 1, 2024
@paul-tavares paul-tavares requested a review from a team as a code owner April 1, 2024 13:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@paul-tavares paul-tavares requested review from pzl and MadameSheema and removed request for dasansol92 and gergoabraham April 1, 2024 13:05
Copy link
Member

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paul-tavares paul-tavares changed the title [Security Solution][Endpoint] Skip failing tests for serverless [Security Solution][Endpoint] Re-enable skipped tests Apr 1, 2024
@paul-tavares paul-tavares force-pushed the task/olm-skip-failing-tests-due-to-fleet-api-version-error branch from 4866d20 to f5ab813 Compare April 1, 2024 16:07
@paul-tavares
Copy link
Contributor Author

@pzl , @MadameSheema - can you take another look. PR purpose was changed to re-enable skipped test (Kibana Ops got the the skip before this PR)

Copy link
Member

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@pzl pzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #200303 succeeded 4866d209c438f37a09dea378eab1f0e0249e2d63
  • 💔 Build #200297 failed 4e25cd5e96ef85aaa09e2510868aed37ea680b5a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @paul-tavares

@paul-tavares paul-tavares merged commit e364fee into elastic:main Apr 1, 2024
34 checks passed
@paul-tavares paul-tavares deleted the task/olm-skip-failing-tests-due-to-fleet-api-version-error branch April 1, 2024 19:17
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test: Security Solution Cypress.x-pack/plugins/security_solution/public/management/cypress/e2e/response_actions/response_console/file_operations·cy·ts - Response console File operations: "before all" hook for ""get-file --path" - should retrieve a file" "before all" hook for ""get-file --path" - should retrieve a file" Failing test: Security Solution Cypress.x-pack/plugins/security_solution/public/management/cypress/e2e/response_actions/response_console/execute·cy·ts - Response console Execute operations: "before all" hook for ""execute --command" - should execute a command" "before all" hook for ""execute --command" - should execute a command" Failing test: Security Solution Cypress.x-pack/plugins/security_solution/public/management/cypress/e2e/endpoint_alerts·cy·ts - Endpoint generated alerts "before each" hook for "should create a Detection Engine alert from an endpoint alert" "before each" hook for "should create a Detection Engine alert from an endpoint alert" Failing test: Security Solution Cypress.x-pack/plugins/security_solution/public/management/cypress/e2e/automated_response_actions/automated_response_actions·cy·ts - Automated Response Actions From alerts "before all" hook for "should have generated endpoint and rule" "before all" hook for "should have generated endpoint and rule" Failing test: Security Solution Cypress.x-pack/plugins/security_solution/public/management/cypress/e2e/endpoint_list/endpoints·cy·ts - Endpoints page "before all" hook for "Shows endpoint on the list" "before all" hook for "Shows endpoint on the list"
6 participants