Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[infra] telemetry can be undefined #175036

Merged
merged 2 commits into from
Jan 18, 2024
Merged

[infra] telemetry can be undefined #175036

merged 2 commits into from
Jan 18, 2024

Conversation

klacabane
Copy link
Contributor

@klacabane klacabane commented Jan 17, 2024 •
edited
Loading

Summary

Closes #175026

Telemetry service can be undefined when source is loaded from non-infra plugin context

Testing

  • create a metric rule
  • fields can be loaded and preview graph is showing in the metric creation panel

@klacabane klacabane added bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature labels Jan 17, 2024
@klacabane klacabane requested a review from a team as a code owner January 17, 2024 15:24
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@klacabane klacabane added the release_note:skip Skip the PR/issue when compiling release notes label Jan 17, 2024
mykolaharmash
mykolaharmash reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@mykolaharmash mykolaharmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we also modify InfraClientStartDeps interface in x-pack/plugins/infra/public/types.ts to make telementry optional.

@klacabane klacabane requested review from a team as code owners January 18, 2024 14:24
mykolaharmash
mykolaharmash approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@mykolaharmash mykolaharmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.3MB 1.3MB +27.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@klacabane klacabane merged commit 3231672 into elastic:main Jan 18, 2024
17 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Jan 18, 2024
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@klacabane @CoenWarmer
[infra] telemetry can be undefined (elastic#175036)
d99698a 
## Summary

Closes elastic#175026

Telemetry service can be undefined when source is loaded from non-infra
plugin context

### Testing
- create a metric rule
- fields can be loaded and preview graph is showing in the metric
creation panel
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@klacabane @CoenWarmer
[infra] telemetry can be undefined (elastic#175036)
7dd7d80 
## Summary

Closes elastic#175026

Telemetry service can be undefined when source is loaded from non-infra
plugin context

### Testing
- create a metric rule
- fields can be loaded and preview graph is showing in the metric
creation panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykolaharmash mykolaharmash mykolaharmash approved these changes

@fkanout fkanout fkanout approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG][OBS-UX-MNGT] Metric threshold rule is no longer fetching source
6 participants
@klacabane @apmmachine @kibana-ci @mykolaharmash @fkanout @kibanamachine