Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] hosts table metrics #173708
[infra] hosts table metrics #173708
Changes from 14 commits
5c78e31
65326dc
d7c0a84
d6be806
b40969e
d754285
799788d
866b033
f173687
ecd2ab9
9de1787
399c5b4
e315868
4f157da
066ae0b
12e9220
7ed6817
2344594
954b1e9
c6d80a1
43e2f73
2bee796
a6ac829
95b0b2d
ede719b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice 🤩 I am happy to see that we can use synthrace for host test data generation 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After I checked the telemetry cluster again I saw that the duration is available there (passed on line 77) Do we need the
value1
in this case (or do we want it because we want to use thedata_load
key)? I see the same data in the Time Series chart selectingvalue1
andduration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now we only record the data loading duration, I've set it as
key1
if we want to extend the event with more metrics (ie render time) but atm using eitherduration
orvalue1
is similar.Looking at metrics again I can't find the actual duration of the journey, we get different events associated with the journey (
getAllTag
,kibana_loaded
..) but I'm not sure if one of these actually represents the journey execution time @dmlemeshko do you know how we can get the journey duration ?