Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDR Workflows][E2E] Recreate agent on createEndpointHost task fail #169092

Merged
merged 47 commits into from
Oct 25, 2023

Conversation

szwarckonrad
Copy link
Contributor

@szwarckonrad szwarckonrad commented Oct 17, 2023

Restart vagrant vm on error during beforeAll task createEndpointHost

Defend Workflows Cypress suite ran 300 times through flaky test runner:

  1. 100x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3699
  2. 50x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3707
  3. 50x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3708
  4. 50x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3709
  5. 50x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3710

Flaky test runner runs with createEndpointHost task failure with successful recovery:

  1. https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3710#018b62fd-9ae9-4988-b1e0-ab0f04d8efdc
  2. https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3710#018b62fd-9ae6-4340-992b-1474ee0f114b
  3. https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3708#018b62fd-578e-4817-ae1c-8c58e8774eec
  4. https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3708#018b62fd-5787-4245-85a6-cb446e42bc73
  5. https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3707#018b62fc-fc17-407e-88de-d0b43b6b1d44 (failed due to unrelated issue)
  6. https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3699#018b61d9-d2c3-430c-b3e3-72b9fbb22d24
  7. https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3699#018b61d9-d2c6-4315-b828-b3218a70f209
  8. https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3699#018b61d9-d2c7-4ff7-9a70-7354f90179e0
  9. https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3699#018b61d9-d2d7-418f-b043-049e5effb26f
  10. https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3699#018b61d9-d2da-47cc-b4ea-a4d4de3ba0a0

New errors not spotted before that got to do with env set up:

  1. vagrant up failed:
    1.1 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3708#018b62fd-5787-4245-85a6-cb446e42bc73
    1.2 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3699#018b61d9-d2d0-4a52-87d9-34caa8927465

  2. CypressError: cy.task('indexFleetEndpointPolicy')timed out after waiting60000ms`.:
    2.1 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3707#018b62fc-fc04-40d4-b155-46f094681edb
    2.2 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3699#018b61d9-d2c9-4ebb-9174-eb9d79d04d02
    2.3 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3699#018b61d9-d2dc-438f-94b0-9f94ae95701c

Closes:
#168284
#169343
#169468
#169469
#169467
#169465
#169466
#169157
#168719
#168427
#168359
#168340
#169689

@szwarckonrad szwarckonrad self-assigned this Oct 25, 2023
@szwarckonrad szwarckonrad added release_note:skip Skip the PR/issue when compiling release notes v8.12.0 Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Oct 25, 2023
@szwarckonrad szwarckonrad changed the title Before all debug [EDR Workflows][E2E] Recreate agent on createEndpointHost task fail Oct 25, 2023
@szwarckonrad szwarckonrad marked this pull request as ready for review October 25, 2023 09:58
@szwarckonrad szwarckonrad requested review from a team as code owners October 25, 2023 09:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive 👏 🚀

Copy link
Contributor

@delanni delanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flaky runner changes, ok

Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @szwarckonrad 🙇

@szwarckonrad szwarckonrad enabled auto-merge (squash) October 25, 2023 10:25
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #4 / Save Timeline Prompts "before each" hook for "When user navigates to the page where timeline is present, Time save modal should not exists." "before each" hook for "When user navigates to the page where timeline is present, Time save modal should not exists."

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @szwarckonrad

@szwarckonrad szwarckonrad merged commit 1fdcb41 into elastic:main Oct 25, 2023
36 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 25, 2023
This was referenced Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants