Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra RAFs #167785

Merged

Conversation

drewdaemon
Copy link
Contributor

Summary

As a stop-gap for adding the performance journey, we adding RAF calls to the renderers because Elastic charts was reporting the render prematurely. As of elastic/elastic-charts#2131, the bug in Elastic charts is fixed, so we should remove these.

@drewdaemon drewdaemon marked this pull request as ready for review October 2, 2023 14:13
@drewdaemon drewdaemon requested a review from a team as a code owner October 2, 2023 14:13
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review only

@stratoula stratoula merged commit 0f00371 into elastic:renovate/main-@elasticcharts Oct 2, 2023
5 of 8 checks passed
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #28 / Serverless Common UI - Management Index Templates "before all" hook for "renders the index templates tab"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionGauge 18.8KB 18.7KB -38.0B
expressionHeatmap 27.2KB 27.2KB -38.0B
expressionMetricVis 4.6KB 4.6KB -38.0B
expressionPartitionVis 40.6KB 40.6KB -36.0B
expressionTagcloud 23.0KB 23.0KB -38.0B
expressionXY 131.1KB 131.1KB -38.0B
total -226.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants