[Cases] Fix failed jest tests for all_cases_list #149005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ref HEAD~1..HEAD --fix'
…-ref HEAD~1..HEAD --fix'
js-jankisalvi
added
release_note:skip
cnasikas
added
the
Team:ResponseOps
…ibana into jest-failed-test
js-jankisalvi
commented
Feb 9, 2023
| <AllCasesList /> | ||
| </TestProviders> | ||
| ); | ||
| expect(wrapper.find('[data-test-subj="cases-count-stats"]')).toBeTruthy(); |
There was a problem hiding this comment.
data-test-subj="cases-count-stats" doesn't exist anywhere in all_cases_list and it's child components.
js-jankisalvi
commented
Feb 9, 2023
|
|
||
| // Flaky: https://github.com/elastic/kibana/issues/148490 | ||
| describe.skip('Assignees', () => { |
There was a problem hiding this comment.
This block was outside of main describe block which caused timeout to get mock data of useGetCases
js-jankisalvi
commented
Feb 9, 2023
| ); | ||
| expect( | ||
| screen.getAllByTestId('case-table-column-createdAt')[0].querySelector('.euiToolTipAnchor') | ||
| ).toHaveTextContent(removeMsFromDate(useGetCasesMockState.data.cases[0].createdAt)); |
There was a problem hiding this comment.
we are removing milliseconds in CreatedAt column in use_cases_columns hook, while mock data is with milliseconds.
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
js-jankisalvi
changed the title
jonathan-buttner
approved these changes
Feb 9, 2023
| <AllCasesList /> | ||
| </TestProviders> | ||
| ); | ||
| expect(wrapper.find('[data-test-subj="cases-count-stats"]')).toBeTruthy(); |
| @@ -1020,37 +943,35 @@ describe.skip('AllCasesListGeneric', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it.each(severityTests)('update the status of a case: %s', async (severity) => { | |||
| const res = appMockRenderer.render(<AllCasesList />); | |||
| it.each(severityTests)('update the severity of a case: %s', async (severity) => { | |||
| it('should hide the assignees column on basic license', async () => { | ||
| useLicenseMock.mockReturnValue({ isAtLeastPlatinum: () => false }); | ||
| // Flaky: https://github.com/elastic/kibana/issues/148490 | ||
| describe('Assignees', () => { |
There was a problem hiding this comment.
Let's remove the comment above this
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes failed jest tests for
all_cases_listcomponent.Fixes: #139676, #142763, #148094, #148095, #148096, #148485, #148486, #148487, #148488, #148490, #148491, #148492, #148493, #148343