Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Allow POST URL in Canvas to be copied #117954

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

tsullivan
Copy link
Member

Summary

Closes #117928

image

@tsullivan tsullivan requested review from a team as code owners November 8, 2021 22:17
@tsullivan tsullivan added v7.16.0 v8.0.0 v8.1.0 release_note:skip Skip the PR/issue when compiling release notes Team:AppServicesUx labels Nov 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1003.6KB 1003.6KB +14.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@dokmic dokmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @tsullivan ! This was obviously an oversight when we introduced the guidance for copying.

@tsullivan tsullivan merged commit 24477e9 into elastic:main Nov 10, 2021
@tsullivan tsullivan deleted the reporting/fix-canvas-share-menu branch November 10, 2021 04:53
tsullivan added a commit to tsullivan/kibana that referenced this pull request Nov 10, 2021
tsullivan added a commit to tsullivan/kibana that referenced this pull request Nov 10, 2021
kpatticha pushed a commit to kpatticha/kibana that referenced this pull request Nov 10, 2021
fkanout pushed a commit to fkanout/kibana that referenced this pull request Nov 17, 2021
roeehub pushed a commit to build-security/kibana that referenced this pull request Dec 16, 2021
@sophiec20 sophiec20 added the (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Reporting] Canvas Share menu does not allow POST URL to be copied
7 participants