Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Can't enable chart context menu if the tooltip is too close to the bottom of the screen #171988

Open
markov00 opened this issue Nov 27, 2023 · 4 comments
Labels
blocked bug Fixes for quality problems that affect the customer experience Feature:ElasticCharts Issues related to the elastic-charts library impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@markov00
Copy link
Member

markov00 commented Nov 27, 2023

Kibana version:
main

Describe the bug:

Trying to use right-click on a geometry that is too close to the bottom of the screen could fail opening the context menu due to the scroll bar appearing and disappearing quickly and making the context menu disappear immediately.

Steps to reproduce:

  1. create a stacked bar chart with more then 10 elements
  2. try to right-click on a bar that is close to the bottom of the screen (from within Lens editor)
  3. you will notice that the screen will flick for a frame and the context menu will not appear.

Expected behavior:
The context menu should pop up on a different position but should appear anyway.

Screenshots (if relevant):

Screen.Recording.2023-11-27.at.14.49.25.mov

Any additional context:

Hiding the body overflow help a bit, but the tooltip should recompute its position when open in context menu (cc @nickofthyme )

The same behaviour is also visible in dashboard

@markov00 markov00 added bug Fixes for quality problems that affect the customer experience Feature:ElasticCharts Issues related to the elastic-charts library Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Nov 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@stratoula stratoula added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Nov 27, 2023
@stratoula
Copy link
Contributor

@markov00 is this something that can be fixed in kibana?

@markov00
Copy link
Member Author

not fully sure, I believe this could be half charts half Kibana. Kibana has always this scrollable body where we don't actually need it, so probably we need to double-check this too.

@nickofthyme
Copy link
Contributor

nickofthyme commented Nov 27, 2023

Huh that's strange, never seen that before. Popper should be able to place the tooltip no matter the scroll container. I think we need to solve this in charts. @markov00 the pinned state does not change, it's set to true flickers and goes on thinking the tooltip is not pinned, then clicking out of the chart blurs the tooltip and sets pinned to false.

Also tried setting fallback placements and that does nothing to resolve this.

Opened elastic/elastic-charts#2259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Fixes for quality problems that affect the customer experience Feature:ElasticCharts Issues related to the elastic-charts library impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants