Checking failure store used for wrong data_stream.type from 9.2.0 #131583
+13
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A followup of #131261 - starting in 9.2.0, the failure store will be enabled by default for
logs-*-*
data streams, so sending the wrongdata_stream.type
doesn't cause 400s anymore, but rather 201 responses withfailure_store: used
. This causes failures in the compatibility tests, hence this PR.I couldn't find a way to add another test -
Test wrong data_stream type - logs before 9.2.0
(e.g. to that 8.19 builds keep verifying the current behavior), because I don't know how to restrict a REST yaml test from running up to a specific version.@elastic/es-core-infra please review the technical aspect of this.
I am still looking for approval for the conceptual issue of whether stop responding with errors can be considered a non-breaking change by default.