Support Fields API in conditional ingest processors #131581
Open
+637
−364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing whitelist Fix access to dotted field from source in yaml test Separate field access and field modification APIs Extending yaml test to cover all field access APIs Separate WriteField and SourceMapField tests Add test verifying that iterator() API does not allow removal Small test change Caching script instance instead of script factory Update docs/changelog/121914.yaml Initial review changes Removing params from execute Remove todo Removing Field's methods from whitelists [CI] Auto commit changes from spotless Not relying on specific error type in yaml test
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @eyalkoren, I've created a changelog YAML for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrying to add field API support for conditional ingest processors.
@jdconrad I propose a review from fresh, as it is a small one.
Apart from the other things we discussed, note that
SourceMapFieldScriptdoesn't implementgetMetadata, I am not sure if there are implications for that.