Component Templates: Add `{created,modified}_date` #131536

szybia · 2025-07-18T14:53:42Z

Add new system-managed properties to component templates:

created_date: when the template with a given ID was created
modified_date: when the template was updated

…-tracking * upstream/main: (44 commits) Term vector API on stateless search nodes (elastic#129902) TEST Fix ThreadPoolMergeSchedulerStressTestIT testMergingFallsBehindAndThenCatchesUp (elastic#131636) Add inference.put_custom rest-api-spec (elastic#131660) ESQL: Fewer serverless docs in tests (elastic#131651) Skip search on indices with INDEX_REFRESH_BLOCK (elastic#129132) Mute org.elasticsearch.indices.cluster.RemoteSearchForceConnectTimeoutIT testTimeoutSetting elastic#131656 [jdk] Resolve EA OpenJDK builds to our JDK archive (elastic#131237) Add optimized path for intermediate values aggregator (elastic#131390) Correctly handling download_database_on_pipeline_creation within a pipeline processor within a default or final pipeline (elastic#131236) Refresh potential lost connections at query start for `_search` (elastic#130463) Add template_id to patterned-text type (elastic#131401) Integrate LIKE/RLIKE LIST with ReplaceStringCasingWithInsensitiveRegexMatch rule (elastic#131531) [ES|QL] Add doc for the COMPLETION command (elastic#131010) ESQL: Add times to topn status (elastic#131555) ESQL: Add asynchronous pre-optimization step for logical plan (elastic#131440) ES|QL: Improve generative tests for FORK [130015] (elastic#131206) Update index mapping update privileges (elastic#130894) ESQL: Added Sample operator NamedWritable to plugin (elastic#131541) update `kibana_system` to grant it access to `.chat-*` system index (elastic#131419) Clarify heap size configuration (elastic#131607) ...

szybia · 2025-07-22T10:23:09Z

server/src/main/java/org/elasticsearch/cluster/metadata/ComponentTemplate.java

+    // always output millis even if instantSource returns millis == 0
+    private static final DateTimeFormatter ISO8601_WITH_MILLIS_FORMATTER = new DateTimeFormatterBuilder().appendInstant(3)
+        .toFormatter(Locale.ROOT);


can see about putting this into some util method once i merge pipelines PR

same as for pipelines, i can't find anything i can re-use for this functionality

guess i'm asking for votes whether to go util method or fine with duplication of this for pipelines/component and index templates

Have you checked whether there is anything suitable in org.elasticsearch.common.time.DateFormatters? If so, you should certainly use that. If not, I guess we could consider adding it. Might be worth pinging the Core Infra team who own that to see whether they think it's appropriate and if they have a view on the naming.

N.B. That would require you to use a org.elasticsearch.common.time.DateFormatter rather than a java.time.format.DateFormatter. This shouldn't be a problem for you. (I couldn't say why we have this interface: the only implementation of it seems to be the one which ultimately delegates to the JDK class.)

I expect your third PR will introduce a third usage of this pattern, so it's also okay if you do the work to common them up in that third PR.

szybia · 2025-07-22T10:24:36Z

server/src/main/java/org/elasticsearch/cluster/metadata/ComponentTemplate.java

@@ -70,19 +99,23 @@ public static ComponentTemplate parse(XContentParser parser) {
    }

    public ComponentTemplate(Template template, @Nullable Long version, @Nullable Map<String, Object> metadata) {


only used in tests, so no concern about not providing created/modified_date

Copilot

Pull Request Overview

This PR adds system-managed created_date and modified_date tracking properties to component templates in Elasticsearch. These timestamps track when templates are created and last modified.

Key Changes

Extended ComponentTemplate class to include createdDateMillis and modifiedDateMillis fields
Modified template creation/update logic to automatically set these timestamps using an injectable InstantSource
Added validation to prevent users from manually setting these system-managed properties

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
ComponentTemplate.java	Added new timestamp fields, serialization/deserialization, and date formatting
MetadataIndexTemplateService.java	Implemented timestamp logic for template creation and updates with InstantSource injection
PutComponentTemplateAction.java	Added validation to reject user-provided timestamp values
TransportVersions.java	Added new transport version for backward compatibility
Various test files	Updated constructors and assertions to handle new timestamp fields
20_tracking.yml	Added REST API tests for timestamp behavior and validation

Comments suppressed due to low confidence (1)

server/src/main/java/org/elasticsearch/rest/action/admin/indices/RestPutComponentTemplateAction.java:34

[nitpick] The constant name 'COMPONENT_TEMPLATE_TRACKING_INFO' doesn't follow the same naming pattern as the existing constants which describe specific features (e.g., 'SUPPORTS_FAILURE_STORE'). Consider renaming to 'SUPPORTS_COMPONENT_TEMPLATE_TRACKING_INFO' for consistency.

    private static final String COMPONENT_TEMPLATE_TRACKING_INFO = "component_template_tracking_info";

server/src/test/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateServiceTests.java

server/src/main/java/org/elasticsearch/cluster/metadata/ComponentTemplate.java

elasticsearchmachine · 2025-07-22T12:20:10Z

Hi @szybia, I've created a changelog YAML for you.

elasticsearchmachine · 2025-07-22T12:20:10Z

Pinging @elastic/es-data-management (Team:Data Management)

PeteGillinElastic

Thanks, LGTM, just a couple of comments.

PeteGillinElastic · 2025-07-22T15:43:09Z

server/src/main/java/org/elasticsearch/cluster/metadata/ComponentTemplate.java

+    // always output millis even if instantSource returns millis == 0
+    private static final DateTimeFormatter ISO8601_WITH_MILLIS_FORMATTER = new DateTimeFormatterBuilder().appendInstant(3)
+        .toFormatter(Locale.ROOT);


Have you checked whether there is anything suitable in org.elasticsearch.common.time.DateFormatters? If so, you should certainly use that. If not, I guess we could consider adding it. Might be worth pinging the Core Infra team who own that to see whether they think it's appropriate and if they have a view on the naming.

N.B. That would require you to use a org.elasticsearch.common.time.DateFormatter rather than a java.time.format.DateFormatter. This shouldn't be a problem for you. (I couldn't say why we have this interface: the only implementation of it seems to be the one which ultimately delegates to the JDK class.)

...rc/main/java/org/elasticsearch/rest/action/admin/indices/RestPutComponentTemplateAction.java

PeteGillinElastic · 2025-07-22T15:56:46Z

server/src/main/java/org/elasticsearch/cluster/metadata/ComponentTemplate.java

+    // always output millis even if instantSource returns millis == 0
+    private static final DateTimeFormatter ISO8601_WITH_MILLIS_FORMATTER = new DateTimeFormatterBuilder().appendInstant(3)
+        .toFormatter(Locale.ROOT);


I expect your third PR will introduce a third usage of this pattern, so it's also okay if you do the work to common them up in that third PR.

Component Templates: Add {created,modified}_date

430dbd4

elasticsearchmachine added the v9.2.0 label Jul 18, 2025

szybia added 3 commits July 22, 2025 11:29

self-review

692c356

spotless

f52390f

szybia commented Jul 22, 2025

View reviewed changes

szybia requested a review from Copilot July 22, 2025 12:12

Copilot AI reviewed Jul 22, 2025

View reviewed changes

server/src/test/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateServiceTests.java Show resolved Hide resolved

server/src/main/java/org/elasticsearch/cluster/metadata/ComponentTemplate.java Show resolved Hide resolved

szybia added >enhancement :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team labels Jul 22, 2025

szybia marked this pull request as ready for review July 22, 2025 12:19

szybia requested a review from PeteGillinElastic July 22, 2025 12:19

Update docs/changelog/131536.yaml

6a060ab

github-actions bot deployed to docs-preview July 22, 2025 12:20 View deployment

PeteGillinElastic approved these changes Jul 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Component Templates: Add `{created,modified}_date` #131536

Component Templates: Add `{created,modified}_date` #131536

Uh oh!

szybia commented Jul 18, 2025 •

edited

Loading

Uh oh!

szybia Jul 22, 2025 •

edited

Loading

Uh oh!

PeteGillinElastic Jul 22, 2025

Uh oh!

PeteGillinElastic Jul 22, 2025

Uh oh!

szybia Jul 22, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

elasticsearchmachine commented Jul 22, 2025

Uh oh!

elasticsearchmachine commented Jul 22, 2025

Uh oh!

PeteGillinElastic left a comment

Uh oh!

PeteGillinElastic Jul 22, 2025

Uh oh!

Uh oh!

PeteGillinElastic Jul 22, 2025

Uh oh!

Uh oh!

		@@ -70,19 +99,23 @@ public static ComponentTemplate parse(XContentParser parser) {
		}

		public ComponentTemplate(Template template, @Nullable Long version, @Nullable Map<String, Object> metadata) {

Component Templates: Add {created,modified}_date #131536

Are you sure you want to change the base?

Component Templates: Add {created,modified}_date #131536

Uh oh!

Conversation

szybia commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

szybia Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PeteGillinElastic Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

PeteGillinElastic Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

szybia Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

elasticsearchmachine commented Jul 22, 2025

Uh oh!

elasticsearchmachine commented Jul 22, 2025

Uh oh!

PeteGillinElastic left a comment

Choose a reason for hiding this comment

Uh oh!

PeteGillinElastic Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PeteGillinElastic Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Component Templates: Add `{created,modified}_date` #131536

Component Templates: Add `{created,modified}_date` #131536

szybia commented Jul 18, 2025 •

edited

Loading

szybia Jul 22, 2025 •

edited

Loading