Skip to content

Enable force inference endpoint deleting for invalid models and after stopping model deployment fails #129090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dan-rubinstein
Copy link
Member

@dan-rubinstein dan-rubinstein commented Jun 6, 2025

Description

This change modifies the delete inference endpoint API to allow the force option to delete the endpoint even in cases where:

  1. A service can not be found for the endpoint.
  2. The endpoint can not be parsed when reading from the inference index.
  3. Attempting to stop a model deployment for the endpoint fails.

Testing:

  • Tested manually writing an endpoint with an invalid service into the inference index fails to delete with force=false but succeeds with force=true.
  • Tested manually writing an endpoint with an invalid model config (ex. wrong typing for property, extra value, bad chunking settings, etc.) into the inference index fails to delete with force=false but succeeds with force=true.
  • Added a line of code to force the stop model deployment call to fail. Tested that with force=false deleting an endpoint fails when model deployment can not be stopped and with force=true it succeeds leaving behind the model deployment.
  • Unit tests + IT tests

@dan-rubinstein dan-rubinstein added >enhancement :ml Machine learning Team:ML Meta label for the ML team v8.19.0 v9.1.0 labels Jun 6, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @dan-rubinstein, I've created a changelog YAML for you.

@dan-rubinstein dan-rubinstein marked this pull request as ready for review June 20, 2025 14:38
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@dan-rubinstein
Copy link
Member Author

@elasticmachine merge upstream

@dan-rubinstein dan-rubinstein merged commit 9c6cf90 into elastic:main Jul 16, 2025
33 checks passed
szybia added a commit to szybia/elasticsearch that referenced this pull request Jul 22, 2025
…king

* upstream/main:
  Mark watcher NotMultiProjectCapable and replace deprecated multi-project methods (elastic#131313)
  Enable force inference endpoint deleting for invalid models and after stopping model deployment fails (elastic#129090)
  [ML] Remove SageMaker Elastic updates (elastic#131301)
  Refactor AsyncSearchErrorTraceIT to use assertBusy (elastic#131328)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :ml Machine learning Team:ML Meta label for the ML team v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants