Merge open_exchange with data transport call #128494
Draft
+72
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>non-issue
Team:Analytics
|
We started with a single call, but found handling out-of-order exchange requests too complex, so we decided to separate them. |
|
This commit: 188b0a78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to above typical request flow is:
internal:data/read/esql/open_exchange)internal:data/read/esql/exchange)indices:data/read/esql/data)ElasticSearch relies on Netty to make transport as cheap and as performant as possible, but still each transport message has some cost associated with it.
This change:
open_exchangewithdatacall to minimize amount of remote calls required to start a query on the data nodeinternal:data/read/esql/exchangecalls are started after above initialization is done to avoid making calls and receiving empty messages before actual data node computation starts