Skip to content

Refactor TestBuildInfoPluginFuncTest for clarity #128469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025

Conversation

prdoyle
Copy link
Contributor

@prdoyle prdoyle commented May 26, 2025

When I wrote this test, I was a bit careless of what went into the given and then clauses. I'm not sure, but I think this change is more in the spirit of what is supposed to be in each clause.

After this change:

  • when contains only the code that runs the gradle task and fetches its output
  • then contains only assertions covering the expected conditions
  • given contains everything else, and can be referred to as needed to understand the other clauses

@prdoyle prdoyle requested a review from a team as a code owner May 26, 2025 14:40
@prdoyle prdoyle added >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure labels May 26, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label May 26, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@JVerwolf JVerwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prdoyle prdoyle merged commit a78f1f0 into elastic:main May 27, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Entitlements Entitlements infrastructure Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants