Refactor TestBuildInfoPluginFuncTest for clarity #128469
Merged
+16
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I wrote this test, I was a bit careless of what went into the
given
andthen
clauses. I'm not sure, but I think this change is more in the spirit of what is supposed to be in each clause.After this change:
when
contains only the code that runs the gradle task and fetches its outputthen
contains only assertions covering the expected conditionsgiven
contains everything else, and can be referred to as needed to understand the other clauses