[9.0] ESQL: Refactor Greatest and Least functions to use evaluator map (#114036) #128429
+73
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESQL: Refactor Greatest and Least functions to use evaluator map
Description
This PR refactors the
Greatest
andLeast
functions to use an evaluator map for better code organization and maintainability. The changes include:EVALUATOR_MAP
to map data types to their corresponding evaluator factoriestoEvaluator
method to use the map instead of if-else chainsChanges
Greatest.java
:EVALUATOR_MAP
for evaluator factory mappingtoEvaluator
to use map-based lookupgetWriteableName()
Least.java
:EVALUATOR_MAP
for evaluator factory mappingtoEvaluator
to use map-based lookupgetWriteableName()
Testing
All existing tests pass (
GreatestTests.java, LeastTests.java
)GreatestTests.java
LeastTests.java
Test coverage includes:
Related Issues
Closes #114036
Checklist
Backport