Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #5987) Enhancement/5320 add integration test escape secrets in policy #6029

Open
wants to merge 2 commits into
base: 8.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 14, 2024

  • Enhancement

What does this PR do?

Adds integration test for testing escaping secrets in the agent config. This test case replicates the steps outlined in the following issue.

Why is it important?

We currently don't have integration tests covering this use case

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

How to test this PR locally

Run GOTEST_FLAGS='-test.run ^TestEscapingSecretsInPolicy$' mage integration:test for the platforms and packages that you want

Related issues

* enhancement(5320): added integration test and package policy template

* enhancement(5320): updated struct

* enhancement(5320): added test case where we get install package and get diagnostics

* enhancement(5320): updated tests removed template file

* enhancement(5320): updated tests, fixed error in parsing pre-config

* enhancement(5320): added changelog

* enhancement(5320): ran mage addLicenseHeaders

* ehancement(5320): update import order

* enhancement(5320): added force flag to package installation

* enhancement(5320): remove duplicate force flag

* enhancement(5320): remove changelog

* enhancement(5320): updated test case, corrected assertion

(cherry picked from commit e6f7de4)
@mergify mergify bot requested a review from a team as a code owner November 14, 2024 15:45
@mergify mergify bot added the backport label Nov 14, 2024
@mergify mergify bot requested review from michalpristas and andrzej-stencel and removed request for a team November 14, 2024 15:45
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Nov 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants