Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE - wait 8.16 release][8.16](backport #5950) [proxytest] Wait all requests to finish before closing the server #5970

Draft
wants to merge 1 commit into
base: 8.16
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 7, 2024

What does this PR do?

Makes the proxytest to wait all requests to finish before closing the underlying HTTP server

Why is it important?

The request log sometimes happens after the tests has finished, what causes the test to panic

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

go test -count 15000 -timeout 0 -run TestHTTPSProxy ./testing/proxytest/

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #5950 done by [Mergify](https://mergify.com).

)

(cherry picked from commit e423d73)

# Conflicts:
#	testing/proxytest/proxytest.go
@mergify mergify bot requested a review from a team as a code owner November 7, 2024 14:21
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Nov 7, 2024
@mergify mergify bot requested review from michel-laterman and swiatekm and removed request for a team November 7, 2024 14:21
Copy link
Contributor Author

mergify bot commented Nov 7, 2024

Cherry-pick of e423d73 has failed:

On branch mergify/bp/8.16/pr-5950
Your branch is up to date with 'origin/8.16'.

You are currently cherry-picking commit e423d735b9.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   testing/proxytest/proxytest.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@AndersonQ AndersonQ changed the title [8.16](backport #5950) [proxytest] Wait all requests to finish before closing the server [DO NOT MERGE - wait 8.16 release][8.16](backport #5950) [proxytest] Wait all requests to finish before closing the server Nov 7, 2024
@AndersonQ AndersonQ requested review from AndersonQ and removed request for michel-laterman and swiatekm November 7, 2024 16:22
@AndersonQ AndersonQ marked this pull request as draft November 7, 2024 16:22
Copy link
Contributor Author

mergify bot commented Nov 11, 2024

This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏

Copy link
Contributor Author

mergify bot commented Nov 14, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.16/pr-5950 upstream/mergify/bp/8.16/pr-5950
git merge upstream/8.16
git push upstream mergify/bp/8.16/pr-5950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant