Add local disk cache and concurrent downloads for changelog bundles#3722
Merged
Conversation
The CdnChangelogFetcher now caches individual bundle files on disk
keyed by product/fileName/etag (mirroring CrossLinkFetcher's pattern)
so repeated builds and dev-server reloads skip unchanged downloads.
Bundle downloads within a product are now fired concurrently via
Task.WhenAll instead of sequentially.
Also fixes ChangelogRegistryBundle.ETag deserialization by adding an
explicit [JsonPropertyName("etag")] — the SnakeCaseLower policy
produced "e_tag" which never matched the CDN's actual field name.
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
reakaleek
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every
docs-builderinvocation (and every dev-server file-change reload) re-downloads all changelog bundle YAML files from CloudFront, even though they rarely change. This adds noticeable latency to builds, especially in theservepath where reloads are frequent. The cross-link fetcher already avoids this with ETag-based local caching; changelogs had no equivalent.What
~/.../elastic/docs-builder/changelog-bundles/keyed by{product}-{fileName}-{etag}, mirroring the CrossLinkFetcher pattern. The registry.json is always fetched (it's small and provides fresh ETags for cache validation).Task.WhenAll) instead of sequential.ChangelogRegistryBundle.ETagdeserialization by adding an explicit[JsonPropertyName("etag")]— theSnakeCaseLowernaming policy was producinge_tagwhich never matched the CDN's actual field name, so the field was always null.Made with Cursor