Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add substitutions for curator_version and curator_major #1743

Merged
merged 3 commits into from
Mar 26, 2025

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Feb 28, 2025

Relates to #1737 (comment)

Proposed Changes

This PR adds substitutions for the curator version, which is currently used in the installation examples.

Per elastic/docs-builder#699, the use of substitutions in codeblocks is supported by adding https://docs-v3-preview.elastic.dev/elastic/docs-builder/tree/main/syntax/substitutions#code-directive-with-subs-enabled

@untergeek untergeek marked this pull request as ready for review March 1, 2025 00:00
@untergeek untergeek self-requested a review March 1, 2025 00:00
Copy link
Member

@untergeek untergeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM™

@lcawl lcawl marked this pull request as draft March 1, 2025 00:08
@lcawl
Copy link
Contributor Author

lcawl commented Mar 1, 2025

I'll refrain from merging until elastic/docs-builder#661 is solved.

@lcawl lcawl marked this pull request as ready for review March 26, 2025 06:10
@lcawl lcawl merged commit 06160d4 into elastic:master Mar 26, 2025
3 checks passed
@lcawl lcawl deleted the curator-applies branch March 26, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants