Skip to content

[Doc] fix use_performance_counters documented default value as false#51657

Open
jguay wants to merge 2 commits into
elastic:mainfrom
jguay:use_performance_counters-defaults-to-false
Open

[Doc] fix use_performance_counters documented default value as false#51657
jguay wants to merge 2 commits into
elastic:mainfrom
jguay:use_performance_counters-defaults-to-false

Conversation

@jguay

@jguay jguay commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Proposed commit message

This is just fixing documentation about default value of use_performance_counters being false (since 8.16) and not true

Disruptive User Impact

None

How to test this PR locally

Doc change so no particular test needed

Related issues

Use cases

N/A

Screenshots

N/A

Logs

N/A

@jguay jguay requested a review from a team as a code owner June 30, 2026 14:59
@jguay jguay requested review from belimawr and rdner June 30, 2026 14:59
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
  • /test : Run the Buildkite pipeline.

@mergify mergify Bot assigned jguay Jun 30, 2026
@mergify

mergify Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @jguay? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

An error occurred during the review process. Please try again later.

📝 Walkthrough

Walkthrough

In metricbeat/module/system/core/_meta/docs.md, a single line was updated: the typo "machins" was corrected to "machines" and the documented default value for use_performance_counters was changed from true to false.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ Update Documentation

Warning

Tools execution failed with the following error:

Failed to run tools: 14 UNAVAILABLE: read ECONNRESET


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@ebeahan ebeahan added backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team skip-changelog labels Jul 1, 2026
@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 1, 2026
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@ebeahan

ebeahan commented Jul 1, 2026

Copy link
Copy Markdown
Member

@jguay please try running make check locally - looks like these changes propagate to another file which needs committed as well: https://github.com/elastic/beats/actions/runs/28454447514/job/84325241712?pr=51657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Skip notification from the automated backport with mergify skip-changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants