feat(8.16): bump beats to latest version #14471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…14147)" (elastic#14309)" This reverts commit dd3cbe4.
pin ristretto to a version before generics was added to not break binary compatibility
kruskall
force-pushed
the
bump/beats-8.16
branch
from
12c650a
to
ef6d6dd
Compare
1pkg
reviewed
Oct 31, 2024
| @@ -177,3 +173,5 @@ replace ( | |||
| // command line flags and conflicting with command line flags added by libbeat. | |||
| github.com/golang/glog => ./internal/glog | |||
| ) | |||
|
|
|||
| replace github.com/dgraph-io/ristretto v0.1.2-0.20240116140435-c67e07994f91 => github.com/dgraph-io/ristretto v0.2.0 | |||
There was a problem hiding this comment.
can we add a comment above on why we are doing thing?
There was a problem hiding this comment.
how is this even working as intended?
the API might have changed between 0.1 and 0.2 🤔
is there another dependency that requires 0.1? otherwise I don't see why Go modules MVS sholdn't figure out autonomously to use 0.2
There was a problem hiding this comment.
The version is misleading :(
github.com/dgraph-io/ristretto v0.1.2-0.20240116140435-c67e07994f91 is https://github.com/dgraph-io/ristretto/tree/c67e07994f911dbf42104f568c83a29830e88236 which was pushed at some point between 0.2.0 and 1.0.0 (dgraph-io/ristretto@v0.2.0...v1.0.0)
We're pinning to v0.2.0 becuase v1.0.0 added generics
1pkg
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Revert beats bump revert but pin the ristretto version to keep using badger v2 (since the version is binary compatible)
Checklist
For functional changes, consider:
How to test these changes
Related issues
Related to #11546
Closes #14297