Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changelog: 8.15.3 release #14377

Merged
merged 5 commits into from
Oct 18, 2024
Merged

changelog: 8.15.3 release #14377

merged 5 commits into from
Oct 18, 2024

Conversation

inge4pres
Copy link
Contributor

No description provided.

@inge4pres inge4pres added the docs label Oct 16, 2024
@inge4pres inge4pres requested a review from a team as a code owner October 16, 2024 15:23
lahsivjar
lahsivjar previously approved these changes Oct 16, 2024
View reviewed changes
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 16, 2024

This pull request does not have a backport label. Could you fix it @inge4pres? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 16, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 16, 2024
carsonip
carsonip requested changes Oct 16, 2024
View reviewed changes
changelogs/8.15.asciidoc Outdated

https://github.com/elastic/apm-server/compare/v8.15.2\...v8.15.3[View commits]

No significant changes.
Copy link
Member

@carsonip carsonip Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a big apm-data bump #14003 that contains various changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Carson, I was looking at v8.15.2...update-8.15.3

Is it this? #13950

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only see these changes in the version diffs, 1.10.0 to 1.11.0
elastic/apm-data@v1.10.0...v1.11.0

Apparently only #13703 should be added?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be elastic/apm-data@v1.9.1...v1.11.0 if I'm looking at v8.15.2 correctly.
On top of #13703, there's elastic/apm-data#339 . @lahsivjar any otel lib changes that are significant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, you are correct https://github.com/elastic/apm-server/blob/v8.15.2/go.mod#L10
Though I don't see apm-data PR 339 in elastic/apm-data@v1.9.1...v1.11.0

Copy link
Member

@carsonip carsonip Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I don't see apm-data PR 339 in elastic/apm-data@v1.9.1...v1.11.0

Commit message was too long. It is Centralize retrieving instrumentation scope framework conversion for …

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies... I'll add

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mhmhm that change is already in 8.15.2 changelog entry, not sure why.

apm-server/changelogs/8.15.asciidoc

Lines 32 to 35 in d218c50

[float]
==== Added
- Map OpenTelemetry instrumentation scope to `Service.Framework.*` for all signal types. {pull}13903[13903]

1pkg
1pkg reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@1pkg 1pkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also merged #13884 in 8.15.3, originally I didn't add any changelog record for this, but now I'm not sure if we should?

marclop
marclop previously approved these changes Oct 17, 2024
View reviewed changes
@inge4pres
Copy link
Contributor Author

I'm not sure if we should?

Personally i vote for not including it, because it's not a user-visible change that impacts consuming the product.

carsonip
carsonip requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for being a PITA every time about changelogs. I realize I was wrong in #14186 . The apm-data backport didn't make it on time, and there were 2 entries in 8.15.2 actually slipped into 8.15.3.

changelogs/8.15.asciidoc Outdated Show resolved Hide resolved
changelogs/8.15.asciidoc Show resolved Hide resolved
@carsonip carsonip added the backport-8.16 Automated backport with mergify label Oct 18, 2024
@inge4pres
Copy link
Contributor Author

sorry for being a PITA every time about changelogs.

nw, actually thanks so much for your help on this 🙏🏼
looking forward to automating away all these steps

@inge4pres inge4pres enabled auto-merge (squash) October 18, 2024 08:58
@inge4pres inge4pres removed the request for review from lahsivjar October 18, 2024 09:39
inge4pres and others added 5 commits October 18, 2024 11:40
@inge4pres
changelog: 8.15.3 release
2ad113f 
Signed-off-by: inge4pres <[email protected]>
@inge4pres
add bugfix applied through apm-data bump
80b271e 
Signed-off-by: inge4pres <[email protected]>
@inge4pres
changelog: improve syntax
28b82ac 
Signed-off-by: inge4pres <[email protected]>
@inge4pres @carsonip
amend syntax
a399a84 
Co-authored-by: Carson Ip <[email protected]>
Signed-off-by: inge4pres <[email protected]>
@inge4pres
correct changelog entries
e5b6ef2 
Signed-off-by: inge4pres <[email protected]>
@carsonip carsonip mentioned this pull request Oct 18, 2024
Open
@inge4pres inge4pres merged commit 3da6808 into elastic:main Oct 18, 2024
7 checks passed
mergify bot pushed a commit that referenced this pull request Oct 18, 2024
@inge4pres @mergify
changelog: 8.15.3 release (#14377)
d5821cc 
Signed-off-by: inge4pres <[email protected]>
Co-authored-by: Carson Ip <[email protected]>
(cherry picked from commit 3da6808)
@mergify mergify bot mentioned this pull request Oct 18, 2024
Merged
@inge4pres inge4pres deleted the release/8.15.3 branch October 18, 2024 10:26
mergify bot added a commit that referenced this pull request Oct 21, 2024
@mergify @inge4pres
changelog: 8.15.3 release (#14377) (#14396)
00175f1 
Signed-off-by: inge4pres <[email protected]>
Co-authored-by: Carson Ip <[email protected]>
(cherry picked from commit 3da6808)

Co-authored-by: Francesco Gualazzi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1pkg 1pkg 1pkg left review comments

@carsonip carsonip carsonip approved these changes

@marclop marclop marclop left review comments

@lahsivjar lahsivjar lahsivjar left review comments

Assignees
No one assigned
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@inge4pres @lahsivjar @marclop @carsonip @1pkg