[8.x] Apply shutdown timeout to http server to limit reload delay (backport #14339) #14362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
httpServer.stop may block indefinitely, potentially due to misbehaving connections. Apply shutdown timeout to http server so that in a hot reload, the old and new server overlapping time is bounded. (cherry picked from commit 24329c8)
kruskall
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
httpServer.stop may block indefinitely, potentially due to misbehaving connections.
Apply shutdown timeout to http server so that in a hot reload, the old and new server overlapping time is bounded.
Checklist
For functional changes, consider:
How to test these changes
May need to change the code to hang the http server to observe the shutdown timeout. Alternatively there may be a way to mock a misbehaving http client without code change.
Related issues
Part of #14337
This is an automatic backport of pull request #14339 done by [Mergify](https://mergify.com).