-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add wrapper around libbeat instrumentation to propagate missing tracer config #13653
Conversation
This pull request does not have a backport label. Could you fix it @1pkg? 🙏
NOTE: |
f2ae5e9
to
cf2d85f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would be good (but perhaps not critical) to have a functional test for this. WDYT? Maybe open an issue to add a system test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for adding the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the unit test! left a few nits
…tracer config (#13653) (#13675) Add wrapper to libbeat instrumentation to propagate missing tracer config via apm environmental variables. (cherry picked from commit 0a57bbe) Co-authored-by: Kostiantyn Masliuk <[email protected]>
Motivation/summary
This PR addresses the issue by adding a thin wrapper around libbeat instrumentation to propagate missing tracer config from elastic-agent via environmental variables.
Checklist
For functional changes, consider:
How to test these changes
Follow instructions in
Building an Elastic Agent container image with a locally built APM Server
andRunning an Elastic Agent container with a locally built APM Server
section inTESTING.md
, update the relevantagent.monitoring
sections inelastic-agent.yml
to see the config are propagated down to tracing correctly.Related issues
#13597
#11381
#13514