Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/meteor integration #3811

Closed

Conversation

mahyarkarimi
Copy link

This pull request adds Meteor.js framework integration for node backend. Due to Meteor.js issue with AsyncLocalStorage from "async_hooks" and its async/await implementation with fibers, this feature adds a run-context based on fibers npm package to support complete integration with the Meteor.js.
In order to set names of the transactions the usePathAsTransactionName must be set to true.

Usage:
import client from 'elastic-apm-node-meteor';
client.start({
serverUrl: '...',
serviceName: '...',
environment: '...',
contextManager: 'fibers',
usePathAsTransactionName: true,
});

Checklist

  • Implement code
  • Add tests
  • Update TypeScript typings
  • Update documentation
  • Add CHANGELOG.asciidoc entry
  • Commit message follows commit guidelines

@github-actions github-actions bot added agent-nodejs Make available for APM Agents project planning. community triage labels Jan 2, 2024
@trentm
Copy link
Member

trentm commented Jan 4, 2024

@mahyarkarimi Thank you for the impressive work that you've done here!

Unfortunately we won't be accepting a change to add Fibers support. My understanding (laverdet/node-fibers#450) is that Fibers is no longer a viable option for async programming in recent Node.js versions. We don't want to add a dependency on and support for the fibers package -- it adds some complexity and maintenance burden to this project that we don't want to take on.

@trentm trentm closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning. community triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants