Dazfuller/no data fix #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0_1_13-release #43 +/- ##
==================================================
+ Coverage 90.65% 91.87% +1.22%
==================================================
Files 21 21
Lines 353 357 +4
Branches 61 63 +2
==================================================
+ Hits 320 328 +8
+ Misses 33 29 -4 ☔ View full report in Codecov by Sentry. |
dazfuller
added a commit
that referenced
this pull request
Jun 29, 2024
* change version to 0.1.13-SNAPSHOT * Update project dependencies Updated multiple dependencies across the project, including sbt version, plugin versions, and library versions. These changes help keep the project up to date and potentially benefit from updates and fixes in the newer versions of these dependencies. * Update spark versions This change adds Spark 3.5.1 as a supported version * update apache commons compress library to remove CVE warning * add new option to disable evaluation of formulas when reading the Excel source * Update dependencies and refactor actions workflow (#41) * Update apache poi to 5.2.5 and spark to 3.5.1 * Update scalaTestVersion * Refactor actions workflow * Rollback scala version update due to incompatibilities with coverage dependency * Revert package upload path in actions * add latest 3.4.x release * Dazfuller/no data fix (#43) * implement fix to handle files which contain no data (only headers) * add new resource files for tests * add tests to cover new cases * change version to 0.1.13 --------- Co-authored-by: Jose Soto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42 by checking to see if the last data row is the same as, or before the final header record. If so then an empty row is returned