Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(maintenance): add overriding of lexik maintenance to lock and unlock by site #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(maintenance): add overriding of lexik maintenance to lock and unlock by site #41

wants to merge 1 commit into from

Conversation

xXNoceboXx
Copy link

@xXNoceboXx xXNoceboXx commented Nov 26, 2019 •
edited
Loading

Changelog

### Added
- Added commands to lock and unlock
- Added event listener to determinate site
- Added query
- Added database driver
- Added compiler pass

To do

  • Update the documentation

Subject

The goal of this PR is override LexikMaintenanceBundle to lock and unlock sites on demand by each.

@xXNoceboXx xXNoceboXx changed the title chore(maintenance): add overriding of lexik maintenance to lock and unlock by host WIP: chore(maintenance): add overriding of lexik maintenance to lock and unlock by host Nov 26, 2019
@xXNoceboXx xXNoceboXx force-pushed the chore-lexik-maintenance branch 9 times, most recently from 3018033 to 3f12cfd Compare November 26, 2019 14:08
@coveralls
Copy link

coveralls commented Nov 26, 2019 •
edited
Loading

Coverage Status

Coverage increased (+3.3%) to 52.417% when pulling 09b639a on xXNoceboXx:chore-lexik-maintenance into 33b1466 on ekino:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-20.2%) to 29.442% when pulling 3f12cfd on xXNoceboXx:chore-lexik-maintenance into f6a1c65 on ekino:master.

@xXNoceboXx xXNoceboXx force-pushed the chore-lexik-maintenance branch 2 times, most recently from ca2e442 to 374ad52 Compare November 26, 2019 15:31
@xXNoceboXx xXNoceboXx changed the title WIP: chore(maintenance): add overriding of lexik maintenance to lock and unlock by host WIP: chore(maintenance): add overriding of lexik maintenance to lock and unlock by site Nov 26, 2019
@xXNoceboXx xXNoceboXx force-pushed the chore-lexik-maintenance branch 8 times, most recently from 631b8df to fd6b56c Compare November 28, 2019 13:01
@xXNoceboXx xXNoceboXx changed the title WIP: chore(maintenance): add overriding of lexik maintenance to lock and unlock by site chore(maintenance): add overriding of lexik maintenance to lock and unlock by site Nov 28, 2019
@xXNoceboXx
Copy link
Author

@qsomazzi @mremi @bmaziere @bdejacobet

mazsudo
mazsudo suggested changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@mazsudo mazsudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build/phpunit/junit.xml & composer.lock should not be commited

@xXNoceboXx xXNoceboXx force-pushed the chore-lexik-maintenance branch 4 times, most recently from 051b882 to 6b9ed5b Compare December 2, 2019 08:35
@xXNoceboXx xXNoceboXx force-pushed the chore-lexik-maintenance branch from 6b9ed5b to a198633 Compare December 2, 2019 09:16
@xXNoceboXx
Copy link
Author

@bmaziere it's ok I removed junit.xml and composer.lock

@xXNoceboXx xXNoceboXx requested a review from mazsudo December 2, 2019 09:30
@xXNoceboXx
Copy link
Author

build/phpunit/junit.xml & composer.lock should not be commited

Resolved

mazsudo
mazsudo suggested changes Dec 23, 2019
View reviewed changes
Copy link
Contributor

@mazsudo mazsudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update CHANGELOG file plz?

@mazsudo mazsudo requested a review from mremi December 23, 2019 13:32
@mazsudo
Copy link
Contributor

mazsudo commented Dec 23, 2019

can you rebase too plz @xXNoceboXx ?

@mazsudo
Copy link
Contributor

mazsudo commented Jan 3, 2020

up @xXNoceboXx ;)

@xXNoceboXx xXNoceboXx force-pushed the chore-lexik-maintenance branch 2 times, most recently from 3a1bbcd to 32ba741 Compare January 8, 2020 09:07
@xXNoceboXx xXNoceboXx requested a review from mazsudo January 9, 2020 09:29
@xXNoceboXx xXNoceboXx force-pushed the chore-lexik-maintenance branch from 32ba741 to 670e136 Compare January 14, 2020 12:41
@xXNoceboXx
Copy link
Author

can you update CHANGELOG file plz?

Done

mazsudo
mazsudo suggested changes Jan 17, 2020
View reviewed changes
@xXNoceboXx xXNoceboXx force-pushed the chore-lexik-maintenance branch from 670e136 to ca4d3ba Compare January 17, 2020 14:36
@xXNoceboXx xXNoceboXx requested a review from mazsudo January 17, 2020 14:38
@xXNoceboXx xXNoceboXx force-pushed the chore-lexik-maintenance branch from ca4d3ba to 9d9e707 Compare January 17, 2020 14:39
mremi
mremi reviewed Jan 17, 2020
View reviewed changes
@xXNoceboXx xXNoceboXx force-pushed the chore-lexik-maintenance branch 2 times, most recently from 0cb1883 to 09b639a Compare January 23, 2020 08:26
@xXNoceboXx xXNoceboXx force-pushed the chore-lexik-maintenance branch from 09b639a to 88612ef Compare March 19, 2020 08:27
@xXNoceboXx xXNoceboXx requested a review from mremi June 25, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazsudo mazsudo Awaiting requested review from mazsudo

@mremi mremi Awaiting requested review from mremi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xXNoceboXx @coveralls @mazsudo @mremi