-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refurbishment #2 #44
base: master
Are you sure you want to change the base?
Refurbishment #2 #44
Conversation
RuedigerMoeller
commented
Mar 12, 2014
- better stats output,
- separate VM for each serializer,
- moved to average measurement (median, quantile also implemented but just sysouted)
- categorized all serializers
- tested with cygwin, someone check linux
- preview of stats see https://github.com/RuedigerMoeller/fast-serialization/wiki/TestPage
Why are the output files committed to the repo? Can you remove them? |
The advantage is you can generate various stats without having to re-run 2014-03-13 2:03 GMT+01:00 Kannan Goundan [email protected]:
|
i could np 2014-03-13 2:06 GMT+01:00 Rüdiger Möller [email protected]:
|
I think it's valuable to save the result of test runs, but we should be more precise about it. For example, the file path should include some indication of the hardware/software configuration. For now, let's just remove it and expect people to run it at least once. |
ok, i am at it. currently i denote hardware in the stats, which is flawed 2014-03-13 2:10 GMT+01:00 Kannan Goundan [email protected]:
|
done, afaik i don't need another pull request for the deletion .. |
Hey, sorry, but could you delete |
ok, should I paste the latest result to the wiki ? note i had trouble with 2014-03-13 2:18 GMT+01:00 Kannan Goundan [email protected]:
|
done 2014-03-13 2:20 GMT+01:00 Rüdiger Möller [email protected]:
|
I'll look into the CRLF issue. It's happened before. I wonder if Git has that file in a bad state? Let's wait on posting it to the wiki. We should give people more time to look at the changes and try running the benchmarks themselves. My guess is that one week is an acceptable delay. |
np. I have tested it under Cygwin only .. 2014-03-13 2:27 GMT+01:00 Kannan Goundan [email protected]:
|
Also people should review my classifications. I did not have time to review 2014-03-13 2:29 GMT+01:00 Rüdiger Möller [email protected]:
|