fix: enusre sheet is animated correctly with new framer motion #2407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptammergard
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Amazing work @loodde and @Hadlabergman! ⭐
A properly working exit animation really makes it so much smoother as well!
Let's just rebase this on #2408 before merging, to make sure checks are passing and also to make sure a new version is released when merging.
|
|
|
Storybook Preview: https://606dcc0a2208ee00215fb2d9-ahxqjztygo.chromatic.com/ |
alethenorio
approved these changes
Mar 28, 2024
filiptammergard
force-pushed
the
fix/correctly-animate-sheet-open-close-with-latest-framer-motion
branch
from
0f21208 to
c916466
Compare
With the framer-motion 11.0.18 update the sheet opening animation stopped working. This commit fixes that by moving the motion animation to wrap the dialog content and overlay. The sheet exit animation has been broken prior to the 11.0.18 patch and this commit also fixes that by conditionally rendering the dialog root with isOpen, as is described in the framer motion docs.
filiptammergard
force-pushed
the
fix/correctly-animate-sheet-open-close-with-latest-framer-motion
branch
from
c916466 to
3dff286
Compare
|
I took the opportunity to fix the failing test and to also fix the commitlint issue. FYI @loodde |
|
Feel free to merge when you're ready @loodde. I'm off now, back in November 😅👶 |
loodde
deleted the
fix/correctly-animate-sheet-open-close-with-latest-framer-motion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the framer-motion 11.0.18 update the sheet opening animation stopped working. This commit fixes that by moving the motion animation to wrap the dialog content and overlay. The sheet exit animation has been broken prior to the 11.0.18 patch and this commit also fixes that by conditionally rendering the dialog root with isOpen, as is described in the framer motion docs.
Kudos to @Hadlabergman for debugging!