fix: remove data race when resetting ticker #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is a data race in the Ticker that is triggered when Ticker.Reset and Ticker.IsDurationReached are called concurrently. IsDurationReached is called by the clock as part of Clock.SetTimestamp and Ticker.Reset is called by user-code. This commit fixes the data race by protecting `duration` field of Ticker with the mutex. This also forces inlining of some calls in both methods as the called methods will also attempt to lock the mutex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a data race in the Ticker that is triggered when
Ticker.Reset and Ticker.IsDurationReached are called concurrently.
IsDurationReached is called by the clock as part of Clock.SetTimestamp and
Ticker.Reset is called by user-code.
This commit fixes the data race by protecting
durationfield of Tickerwith the mutex. This also forces inlining of some calls in both methods
as the called methods will also attempt to lock the mutex.