Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a problem with php 8 and civicrm 5.67.1 #261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaapjansma
Copy link
Contributor

When I installed this in our demo environment I discovered a compatibility issue with php 8 and civicrm 5.67.1 and Drupal 10.

Not sure whether this breaks other compatibility, such as Drupal 7, or wordpress or older versions of CiviCRM.

@civibot civibot bot added the master label Dec 6, 2023
@eileenmcnaughton
Copy link
Owner

Thanks @jaapjansma - these files are pulled in by composer so I'm guessing we need to change the version of symfony? There is a big-picture issue around how extensions with composer packages install - here I have committed them which is easy for some frameworks but tricky for others. So consistent with that we would update any package within the extension by doing a composer update & committing the results. I'm just wonder what the various versions of symfony that are involved are.

I might raise over on dev that WMF uses the composer merge plugin package (& then does not commit any vendor directories to our git) - I don't know if that package could be used more broadly

@jaapjansma
Copy link
Contributor Author

@eileenmcnaughton I am not very familiar with composer and extension within a framework. But the composer merge plugin sounds reasonable. Maybe @totten or @mattwire have any thoughts that.

@stesi561
Copy link

This PR is now out of date but this issue is related: #259

@stesi561
Copy link

stesi561 commented Mar 19, 2024

@eileenmcnaughton is it worth updating this PR to update symfony/http-foundation or is there ongoing work here to address the underlying issue? I think currently for D10 we'd need symfony/http-foundation 6.4.x but I'm keen to explore options for composer merge plugin package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants