Implements __serialize and __unserialize

[bastienho]

required for Serializable since PHP 8.1.0

https://www.php.net/manual/en/class.serializable.php

[eileenmcnaughton]

@bastienho can we just call the existing serialize & unserialize functions - that clean up function for class removes some stuff that doesnt serialize well/ blows out the size / may have sensitive info

[bastienho]

@eileenmcnaughton this was my first thought, but serialize() returns a string and _serialize() HAVE TO return an array.

[eileenmcnaughton]

@bastienho ok - so we should probably do the same things the cleanup function does in that function too - slightly differently as we would perhaps take get_object_vars & filter stuff out

    if (\Civi::settings()->get('omnipay_developer_mode') && !empty($this->history)) {
      $this->logHttpTraffic(FALSE);
    }
    $this->history = [];
    $this->client = NULL;
    $this->lock = NULL;
    $this->guzzleClient = NULL;
    if ($isIncludeGateWay) {
      $this->gateway = NULL;
    }

[bastienho]

I Agree

Should I implement this code in my PR ?

[eileenmcnaughton]

@bastienho that would be great

[bastienho]

After some tests, we can keep the same behaviour in both functions.

So I suggest to implement the cleanup function in __serialize() and call it in serialize()

[bastienho]

@eileenmcnaughton, based on your thougths, I've revamped by PR.

Specially, the implementation of cleanupObjectForSerialization() is not insignificant.

[eileenmcnaughton]

thanks @bastienho I'll take a look - I've tagged a release in the meantime to get the regression fix out