Fix for #198: Double Receipts & Payment Details from Cybersource Payments #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Cybersource Payments
|
@eileenmcnaughton Thanks. The commit you referenced (1a13442) is just a one-line change with commit message "Type hint". Maybe you intended to reference c8b9ab3 , which has the commit message "Fix lock to not release & die" and actually adds that |
|
er yes.... |
eileenmcnaughton
force-pushed
the
master
branch
3 times, most recently
from
8f31154
to
679df0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch solves the problem explained in #198 related to Cybersource, and it seems (to me) like it should not negatively affect other processors. However, see my comment in that ticket expressing uncertainty over why this patch would even be needed.
In other words, this solves the problem, but I don't know why.