Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add goernance module comms test #19

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

eloylp
Copy link
Member

@eloylp eloylp commented Jan 26, 2025

Describe the changes

  1. Did little refactor to better organise tests.
  2. Adds governance module test, that ensures the realyer can communicate with the governance module via gmp.

Related Issue(s)

Closes https://github.com/eigerco/solana-axelar-internal/issues/634

Checklist

  • Tests have been added/updated for the changes.
  • Documentation has been updated for the changes (if applicable). (Not applicable)
  • The code follows Rust's style guidelines.

axelar-message-primitives = { git = "ssh://git@github.com/eigerco/solana-axelar-internal.git", rev = "443377d" }
axelar-executable = { git = "ssh://git@github.com/eigerco/solana-axelar-internal.git", rev = "443377d" }
its-instruction-builder = { git = "ssh://git@github.com/eigerco/solana-axelar-internal.git", rev = "443377d" }
interchain-token-transfer-gmp = { git = "ssh://git@github.com/eigerco/solana-axelar-internal.git", rev = "443377d" }

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being changes to internal because we have the latest gov module id change in the next branch, that is not pushed in the public repo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails because of this of course ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also pushed the next branch to the public repo, you can push the latest next changes from the internal one to the public repo and use that one. Then we can merge as-is

@eloylp eloylp force-pushed the add-governance-tests branch from 6222c16 to cca9938 Compare January 27, 2025 19:59
@eloylp eloylp self-assigned this Jan 27, 2025
@eloylp eloylp closed this Jan 27, 2025
@eloylp eloylp reopened this Jan 27, 2025
@eloylp eloylp force-pushed the add-governance-tests branch from cca9938 to 04bacc8 Compare January 27, 2025 20:26
@eloylp eloylp force-pushed the add-governance-tests branch from 04bacc8 to 287e22c Compare January 27, 2025 20:34
axelar-message-primitives = { git = "ssh://git@github.com/eigerco/solana-axelar-internal.git", rev = "443377d" }
axelar-executable = { git = "ssh://git@github.com/eigerco/solana-axelar-internal.git", rev = "443377d" }
its-instruction-builder = { git = "ssh://git@github.com/eigerco/solana-axelar-internal.git", rev = "443377d" }
interchain-token-transfer-gmp = { git = "ssh://git@github.com/eigerco/solana-axelar-internal.git", rev = "443377d" }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also pushed the next branch to the public repo, you can push the latest next changes from the internal one to the public repo and use that one. Then we can merge as-is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants