fix: prevent histogram render error on initial no data state

eidam · Nov 22, 2020 · 5a086f5 · 5a086f5
1 parent a3c928b
commit 5a086f5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/components/monitorHistogram.js b/src/components/monitorHistogram.js
@@ -39,7 +39,7 @@ export default function MonitorHistogram({ monitorId, kvMonitor }) {
               <span className="font-semibold text-sm">
                 {dayInHistogramLabel}
               </span>
-              {kvMonitor.checks.hasOwnProperty(dayInHistogram) &&
+              {kvMonitor && kvMonitor.checks.hasOwnProperty(dayInHistogram) &&
                 Object.keys(kvMonitor.checks[dayInHistogram].res).map((key) => {
                   return (
                     <>

diff --git a/src/functions/helpers.js b/src/functions/helpers.js
@@ -1,14 +1,16 @@
 import config from '../../config.yaml'
 import { useEffect, useState } from 'react'
 
+const kvDataKey = 'monitors_data_v1_1'
+
 export async function getKVMonitors() {
   // trying both to see performance difference
-  return KV_STATUS_PAGE.get('monitors_data', 'json')
-  //return JSON.parse(await KV_STATUS_PAGE.get('monitors_data', 'text'))
+  return KV_STATUS_PAGE.get(kvDataKey, 'json')
+  //return JSON.parse(await KV_STATUS_PAGE.get(kvDataKey, 'text'))
 }
 
 export async function setKVMonitors(data) {
-  return setKV('monitors_data', JSON.stringify(data))
+  return setKV(kvDataKey, JSON.stringify(data))
 }
 
 export async function setKV(key, value, metadata, expirationTtl) {