Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

adding time conversion function #180

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AKASHAGARWAL0403
Copy link

No description provided.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! If you checkout the build you'll see why it's failing. It's due to linting issues. Please fix those! You can run this locally with npm run validate.

Good luck!

@kentcdodds
Copy link
Member

Hi @AKASHAGARWAL0403! Looking good! Now it looks like we're missing some coverage. Open up coverage/lcov-report/index.html in your web browser to see which parts of the code are missing tests then add tests for those 👌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants