Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Multi-Grab Issue #744

Closed
wants to merge 2 commits into from
Closed

Fix Multi-Grab Issue #744

wants to merge 2 commits into from

Conversation

VinniTR
Copy link
Contributor

@VinniTR VinniTR commented Nov 9, 2024

@VinniTR
Copy link
Contributor Author

VinniTR commented Nov 11, 2024

@efroemling after multiple tests I came to the conclusion that this could not be completely solved, when you quickly grab a bomb near a character it is marked as grabbed but we did not grab it, I thought I had easily solved it by changing the AND for OR but Another problem with the tnt and the flag appeared, this definitely has to be fixed in the c ++ layer.

@VinniTR VinniTR closed this Nov 11, 2024
@EraOSBeta
Copy link
Contributor

EraOSBeta commented Nov 14, 2024

The real issue is how a grab operates: you would normally want the grab to simply affect the first thing it collides with and be over, but since Eric wanted to prioritize flags over other objects in a grab, we have to go through every collision the grab makes and the problems caused by this prioritization method don't have any clean fixes, even in the native layer. Another funny byproduct of this method is that bs.DroppedMessages are dropped for objects that are replaced in the grab while bs.PickedUpMessagess aren't.
Either way the prioritization of flags in grabs is something necessary but we should discuss what other methods can be used for doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants