Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to ProactorEventLoop #722

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

brostosjoined
Copy link
Contributor

Tested the change and magically there isn't set_wakeup_fd errors

Tested the change and magically there isn't `set_wakeup_fd` errors
check_linux vishu
@efroemling
Copy link
Owner

Can you give me a little background on this (or point me to some if it's out there already)? And which version of windows do you see the set_wakeup_fd errors?

@brostosjoined
Copy link
Contributor Author

So on previous bombsquad version you switced to using WindowsSelectorEventLoop due to the error set_wakeup_fd only works in the main thread, on test build 1.7.37 i reverted the change to the default windows event loop which is the ProactorEventLoop
and found that it works fine without the set_wakeup_fd errors.
I made this pull request to revert the loop to use the default which is the ProactorEventLoop so in future we detect what causes the errors maybe debug and fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants