Log cleanup

[efrecon]

Improve logging through silencing non-important errors and improving message accuracy.

Summary by CodeRabbit

• Bug Fixes
  • Suppressed error messages in logging functionality to improve clarity.
  • Modified process termination to handle errors gracefully and enhance reliability.
  • Improved log messages for process termination to differentiate between types of exit signals for better diagnostics.

[coderabbitai]

Walkthrough

The recent updates focus on improving error handling and logging within the system. Modifications include suppressing error messages in a logging function, adjusting process termination commands to silently handle errors, and refining log messages for process termination in a runner script. These changes aim to enhance the system's robustness and clarity in operation monitoring, ensuring smoother and quieter error management and clearer differentiation between types of exit signals in logs.

Changes

File(s)	Change Summary
lib/common.sh	Redirected tail output in sublog function to /dev/null to suppress error messages.
orchestrator.sh	Modified cleanup() to redirect stderr of kill command to /dev/null and added `
runner/.../runner.sh	Updated runner_unregister function to distinguish between termination and exit signals, adjusting log messages accordingly.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 343ea9c and eefc44d.

Files selected for processing (3)

• lib/common.sh (1 hunks)
• orchestrator.sh (1 hunks)
• runner/runner.sh (1 hunks)

Additional comments: 3

orchestrator.sh (1)

• 96-96: The modification to the kill command effectively silences non-critical error messages, aligning with the PR's objectives. However, consider checking if the process exists before attempting to kill it to avoid unnecessary command execution.

lib/common.sh (1)

• 209-209: Suppressing error messages from the tail command aligns with the PR's objectives. Consider adding a comment explaining why stderr is redirected to /dev/null for clarity to future maintainers.

runner/runner.sh (1)

• 239-243: Differentiating between termination signals and regular exit signals in the log messages enhances logging accuracy. Consider adding more detailed comments explaining the signal handling logic for clarity to future maintainers.