Fix: Python value field on enum type should be str #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation returns the integer value of the numeration but Babeltrace 1.X was returning the text label. To ensure compatibility with Babeltrace 1.X, when getting the value of an enum field, return a string containing the corresponding label for this value. This commit also adds a test for this behaviour. Signed-off-by: Francis Deslauriers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation returns the integer value of the numeration
but Babeltrace 1.X was returning the text label.
To ensure compatibility with Babeltrace 1.X, when getting the value of
an enum field, return a string containing the corresponding label for
this value.
This commit also adds a test for this behaviour.
Signed-off-by: Francis Deslauriers [email protected]