Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rule no-on #157

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

rule no-on #157

wants to merge 2 commits into from

Conversation

gearonix
Copy link
Contributor

closes #117

Added this rule to the future preset

@igorkamyshev
Copy link
Member

Thanks for the contribution 😇 I'll take a look this week.

igorkamyshev
igorkamyshev requested changes Feb 26, 2024
View reviewed changes
Copy link
Member

@igorkamyshev igorkamyshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add documentation for the rule? All other stuff is great, I'll merge it as soon as the documentation is done.

@gearonix
Copy link
Contributor Author

gearonix commented Mar 2, 2024

Added

@igorkamyshev
Copy link
Member

Added

Sorry, as a maintainer, I have to be mean. The current version of documentation does not explain anything. Why does this rule exist? Why is .on bad?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorkamyshev igorkamyshev igorkamyshev requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule: no-on
2 participants
@gearonix @igorkamyshev