-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use postgres alpine images to add support for PG 17 #61
base: master
Are you sure you want to change the base?
Conversation
so uh @ledermann do you plan to merge this PR or that other one? You've mentioned that this is a good way to handle things so why not move forward with this? |
@lesha-co I can't decide, @eeshugerman is the owner and maintainer of this repo. |
While we are waiting for this to be merged, is there a way to use it already. I have always used this utility for all my postgres backups, and now I have a production project running with postgres 17 just to realise later that this tool is not yet updated to support v17 yet. |
@ak4zh I have my own fork and I've just yesterday uploaded it with 17.2 image: https://hub.docker.com/repository/docker/mrfoto/postgres-backup-s3/general I use it for my own needs, so no guarantees 😅 Maybe best you fork it yourself. If I managed to do it, you know it isn't that hard 😂 |
@miharekar Thanks, I will see if I can figure out the docker image publishing part myself. Forking is fine but I haven’t explored the docker image publish part before, I suppose I need to signup as publisher in docker-hub or something, will give it a try today so I can reuse the image. |
You don't really need to go into trouble of publishing anything just for this one case. What I did is added this repo as a submodule at commit then added a
and that's it. when, if ever, this pr gets merged, I'll either just remove the submodule and use the newly available version from registry, or just change the submodule head or more likely just do nothing because why fixing something that isn't broken |
@eeshugerman can you please merge this PR? |
@miharekar It seems the docker hub has only arm version not for any other arch like amd64 |
@ak4zh yeah, like I said - I built it for my own needs. Feel free to build one yourself |
Postgres publishes alpine versions of Docker images including for PG 17 which was recently released.
So this approach should work better than #60 where we're left to the mercy of Alpine releases 😅