Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use postgres alpine images to add support for PG 17 #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miharekar
Copy link

@miharekar miharekar commented Oct 14, 2024

Postgres publishes alpine versions of Docker images including for PG 17 which was recently released.

So this approach should work better than #60 where we're left to the mercy of Alpine releases 😅

@miharekar miharekar changed the title Use postgres alpine images Use postgres alpine images to add support for PG 17 Oct 15, 2024
@lesha-co
Copy link

lesha-co commented Nov 11, 2024

so uh @ledermann do you plan to merge this PR or that other one?

You've mentioned that this is a good way to handle things so why not move forward with this?

@ledermann
Copy link
Contributor

@lesha-co I can't decide, @eeshugerman is the owner and maintainer of this repo.

@ak4zh
Copy link

ak4zh commented Dec 2, 2024

While we are waiting for this to be merged, is there a way to use it already.
@miharekar Is there a public docker image with these changes applied for v17 ?

I have always used this utility for all my postgres backups, and now I have a production project running with postgres 17 just to realise later that this tool is not yet updated to support v17 yet.

@miharekar
Copy link
Author

@ak4zh I have my own fork and I've just yesterday uploaded it with 17.2 image: https://hub.docker.com/repository/docker/mrfoto/postgres-backup-s3/general

I use it for my own needs, so no guarantees 😅 Maybe best you fork it yourself. If I managed to do it, you know it isn't that hard 😂

@ak4zh
Copy link

ak4zh commented Dec 2, 2024

@miharekar Thanks, I will see if I can figure out the docker image publishing part myself. Forking is fine but I haven’t explored the docker image publish part before, I suppose I need to signup as publisher in docker-hub or something, will give it a try today so I can reuse the image.

@lesha-co
Copy link

lesha-co commented Dec 2, 2024

You don't really need to go into trouble of publishing anything just for this one case.

What I did is added this repo as a submodule at commit 101949343a3eb3187e61965289b82d8e42acbd5e (i.e. this pull request's head)

then added a build (rather than an image) entry to docker-compose file

services:
  backup:
    build:
      context: ./postgres-backup-s3
      args:
        - POSTGRES_VERSION=17
    environment:
      - SCHEDULE
      - ...

and that's it.

when, if ever, this pr gets merged, I'll either just remove the submodule and use the newly available version from registry, or just change the submodule head or more likely just do nothing because why fixing something that isn't broken

@ahmayou
Copy link

ahmayou commented Dec 2, 2024

@lesha-co I can't decide, @eeshugerman is the owner and maintainer of this repo.

@eeshugerman can you please merge this PR?

@ak4zh
Copy link

ak4zh commented Dec 9, 2024

@miharekar It seems the docker hub has only arm version not for any other arch like amd64
I am trying to deploy it with caprover so can't deploy directly through docker-compose.

@miharekar
Copy link
Author

@ak4zh yeah, like I said - I built it for my own needs. Feel free to build one yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants